- 17 Oct, 2022 1 commit
-
-
Dustin L. Howett authored
-
- 16 Oct, 2022 4 commits
-
-
Dustin L. Howett authored
-
Dustin L. Howett authored
-
Dustin L. Howett authored
I had to import my getopt_long shim from WinLn and switch it to 8-bit char (from wchar_t). The win32 global mutex implementation isn't tested yet. A bunch of empty headers have been added to ease compilation of Linux-origin code. Some commands are inaccessible/inoperable (keyscan, stress_test). It must be built with clang-cl.
-
Dustin L. Howett authored
-
- 14 Oct, 2022 1 commit
-
-
Tom Hughes authored
_exit() is called by libc functions such as abort() or exit(). This implementation replaces the one from newlib's libnosys. BRANCH=none BUG=b:234181908 TEST=make buildall Signed-off-by:
Tom Hughes <tomhughes@chromium.org> Change-Id: I1d8f65fa206b3544a2772f38be854ee905532ad3 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3933256 Reviewed-by:
Andrea Grandi <agrandi@google.com>
-
- 13 Oct, 2022 2 commits
-
-
Tom Hughes authored
These macros are easier to read and use than the underlying pragmas. BRANCH=none BUG=b:172020503 TEST=make buildall Signed-off-by:
Tom Hughes <tomhughes@chromium.org> Change-Id: I2f67cbb3f83230b7e1a6a4512471bbd2bec0498f Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3872552 Reviewed-by:
Jack Rosenthal <jrosenth@chromium.org> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
-
Jeremy Bettis authored
Sometimes we get coverage reports where it appears that the coverage data is all shifted off by one line, leaving many comments and blank lines uncovered. For example see http://goto.google.com/cros-ec-coverage/firmware-zephyr-cov-postsubmit/R108-15179.0.0-72225-8800548096768350721/lcov_rpt/common/keyboard_scan.c.gcov.html In looking at that example, I discovered that for brya, in ro only, when looking at the preprocessor output, the lines get shifted. BRANCH=None BUG=b:253131248 TEST=So many gcc -E runs Signed-off-by:
Jeremy Bettis <jbettis@google.com> Change-Id: I6e852548cb954ed3ee3c47088ed275bc32892753 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3949582 Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Reviewed-by:
Al Semjonovs <asemjonovs@google.com> Tested-by:
Jeremy Bettis <jbettis@chromium.org> Auto-Submit: Jeremy Bettis <jbettis@chromium.org> Commit-Queue: Al Semjonovs <asemjonovs@google.com>
-
- 12 Oct, 2022 5 commits
-
-
Yuval Peress authored
Move the logic of the spi_flash_reg.c from common/ to a separate directory. Also, move the tests. Update the build.mk system to still build this in the same manner as well as CMake to use it as a library. BRANCH=none BUG=b:246839061 TEST=make BOARD=dooly TEST=zmake build hoglin TEST=./twister -T common Signed-off-by:
Yuval Peress <peress@google.com> Change-Id: Icc6b4fce1619c2c6a86c040f30390b7788171a9d Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3935025 Reviewed-by:
Keith Short <keithshort@chromium.org> Reviewed-by:
Aaron Massey <aaronmassey@google.com> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
-
Tom Hughes authored
It's always enabled in the core/<core>/core_config.h files. The following script demonstrates that it's enabled in all boards: for board in `make print-boards`; do make print-configs board="${board}" | grep -q CONFIG_SOFTWARE_PANIC if [ $? -ne 0 ]; then echo "${board} failed" exit 1 fi done BRANCH=none BUG=none TEST=make buildall Cq-Depend: chromium:3943248 Signed-off-by:
Tom Hughes <tomhughes@chromium.org> Change-Id: If683b244f17b48bedf3699f2b24e83b5ad6e849e Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3933255 Reviewed-by:
Daisuke Nojiri <dnojiri@chromium.org> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
-
Tom Hughes authored
When building with clang, it now warns if there is an unpacked struct nested in a packed struct: include/ec_commands.h:3053:4: error: field within 'struct ec_params_motion_sense::(unnamed at include/ec_commands.h:3044:3)' is less aligned than 'union ec_params_motion_sense::(anonymous at include/ec_commands.h:3053:4)' and is usually due to 'struct ec_params_motion_sense::(unnamed at include/ec_commands.h:3044:3)' being packed, which can lead to unaligned accesses [-Werror,-Wunaligned-access] union { ^ See https://github.com/llvm/llvm-project/issues/55520 . BRANCH=none BUG=b:172020503 TEST=./util/compare_build.sh -b all -j 120 => MATCH Signed-off-by:
Tom Hughes <tomhughes@chromium.org> Change-Id: I5c89746d7e2e93183f4706376e6cda0be4589c01 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3946036 Reviewed-by:
Daisuke Nojiri <dnojiri@chromium.org>
-
Harsha B R authored
Fan speed displayed as part of temps command is the ratio of FAN_OFF and FAN_MAX wrt corresponding sensor temperature that tells the amount of cooling the respective sensor expects. This value of fan speed misinterprets as the actual fan_duty. Modify the output of temps command accordingly. CPU Console: localhost ~ # ectool temps all --sensor name -------- temperature -------- ratio (fan_off and fan_max) -- memory 310 K (= 37 C) 8% (308K and 333K) charger 305 K (= 32 C) 0% (308K and 333K) ambient 306 K (= 33 C) 0% (308K and 333K) ectool temps command description temps <sensorid> Print temperature and expected fan ratio (based on temperature, fan_off and fan max value). BUG=b:246929159 TEST=make buildall -j, make -j BOARD=gimble, check temps command description, verify ectool temps all command output in gimble, redrix, brya and nivviks BRANCH=none Signed-off-by:
Harsha B R <harsha.b.r@intel.com> Change-Id: I96286ec7e110ebe64e277d5cfa27e3f489c5893e Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3915760 Reviewed-by:
Daisuke Nojiri <dnojiri@chromium.org> Commit-Queue: Daisuke Nojiri <dnojiri@chromium.org>
-
Tom Hughes authored
In the test build, the "test_mockable_noreturn" helper adds the "__attribute__((weak))" attribute to allow overriding functions. It should still keep the "noreturn" attribute to be consistent with the non-test build. Otherwise, a function declared with "noreturn" that calls one of the functions that uses "test_mockable_noreturn" will fail to compile with: error: function declared 'noreturn' should not return [-Werror,-Winvalid-noreturn] BRANCH=none BUG=b:234181908 TEST=./util/compare_build.sh -b all => MATCH Signed-off-by:
Tom Hughes <tomhughes@chromium.org> Change-Id: I6ebfc78b7b07e19f9305a22fbfeccf62b4000667 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3933258 Reviewed-by:
Jack Rosenthal <jrosenth@chromium.org>
-
- 11 Oct, 2022 1 commit
-
-
Tom Hughes authored
BRANCH=none BUG=b:149987779 TEST=make buildall -j Force-Relevant-Builds: all Signed-off-by:
Tom Hughes <tomhughes@chromium.org> Change-Id: I06cc11dba1f8a37e209ffc3d37a8307832847567 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3404686 Reviewed-by:
Jack Rosenthal <jrosenth@chromium.org>
-
- 10 Oct, 2022 2 commits
-
-
Yuval Peress authored
Rename the shim's board.h and add a conditional include in config.h. This avoids some older boards in zephyr/projects from accidentally including the wrong board since multiple include paths exist. BRANCH=none BUG=b:246839061 TEST=zmake build --all Signed-off-by:
Yuval Peress <peress@google.com> Change-Id: Ice559b83c021506f0cc310a30b4b774527d38f77 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3943255 Reviewed-by:
Keith Short <keithshort@chromium.org> Reviewed-by:
Aaron Massey <aaronmassey@google.com> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
-
Aaron Massey authored
There were two separate masks for clearing the host events. CONFIG_HOST_EVENT_REPORT_MASK for 32 bit host events and CONFIG_HOST_EVENT64_REPORT_MASK for 64 bit host events. Per-build, only one of these would ever be used. At macro-expansion time, set CONFIG_HOST_EVENT_REPORT_MASK to the appropriate mask based on the definition of CONFIG_HOST_EVENT64. BRANCH=none BUG=none TEST=zmake build -a TEST=make runhosttests Signed-off-by:
Aaron Massey <aaronmassey@google.com> Change-Id: I40ddf978c3cf3dfa16dc0e486eaff26a6d56fbe4 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3939623 Commit-Queue: Keith Short <keithshort@chromium.org> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Commit-Queue: Daisuke Nojiri <dnojiri@chromium.org> Reviewed-by:
Daisuke Nojiri <dnojiri@chromium.org> Reviewed-by:
Keith Short <keithshort@chromium.org>
-
- 07 Oct, 2022 1 commit
-
-
Jeremy Bettis authored
If a function in a header is marked as weak (test_mockable), that tells the linker that it is ok for the symbol to be missing. We never want that. If a function implementation is marked as weak, that tells the linker it is ok to use a non-weak symbol instead of this one. This is what we want when we are trying to override functions. Remove all test_mockables from headers, except for one inline function that I wasn't sure what to do with. BRANCH=None BUG=None TEST=make -j$(nproc) runhosttests buildall && zmake build -a && \ ./twister -v -i --clobber LOW_COVERAGE_REASON=Added stub get_ap_reset_stats() for tests that don't care about that function, and it's always unused. Change-Id: Ic00a897131c93ef134544f26a8e368ce1f78a5de Signed-off-by:
Jeremy Bettis <jbettis@google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3935720 Commit-Queue: Jeremy Bettis <jbettis@chromium.org> Auto-Submit: Jeremy Bettis <jbettis@chromium.org> Commit-Queue: Tristan Honscheid <honscheid@google.com> Tested-by:
Jeremy Bettis <jbettis@chromium.org> Reviewed-by:
Tristan Honscheid <honscheid@google.com> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
-
- 06 Oct, 2022 1 commit
-
-
Scott Chao authored
Add bist share mode enable/ disable command. This command will only be effective if system is unlocked. Tested this command by sending Get_Source_Cap command. DUT will return Source Cap with 5V/3A after BIST share mode be enabled. BUG=b:242957100 BRANCH=none TEST=ectool typeccontrol 0 5 [0 | 1] TEST=./twister -v -T zephyr/test TEST=make buildall Change-Id: I307596b9b59d60b72ff1e594919fadfb644dcc53 Signed-off-by:
Scott Chao <scott_chao@wistron.corp-partner.google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3881522 Reviewed-by:
Diana Z <dzigterman@chromium.org> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
-
- 04 Oct, 2022 1 commit
-
-
Michał Barnaś authored
This commit renames the espi vw_slp_s3 config which was missed during the refactoring of all espi host_interface configs. BRANCH=main BUG=b:195416058 TEST=build and run unit tests Change-Id: Ieae131bba14ec17870201a162252b7e2b3ae1d73 Signed-off-by:
Michał Barnaś <mb@semihalf.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3904645 Reviewed-by:
Abe Levkoy <alevkoy@chromium.org>
-
- 03 Oct, 2022 1 commit
-
-
Aaron Massey authored
Verify the EC_CMD_USB_PD_RW_HASH_ENTRY host command appropriately propagates and updates rw hash entries in the rw hash ring-buffer. Scenarios Tested: * Bad rw hash entry * Add rw hash entry * Update rw hash entry BRANCH=none BUG=b:236075275 TEST=twister --clobber -i -s zephyr/test/drivers/drivers.host_cmd Signed-off-by:
Aaron Massey <aaronmassey@google.com> Change-Id: Ifebe658e816e47c4dd3825729cc6e95756278b23 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3930856 Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Reviewed-by:
Tristan Honscheid <honscheid@google.com>
-
- 30 Sep, 2022 1 commit
-
-
Aaron Massey authored
The EC_CMD_PD_HOST_EVENT_STATUS retrieved and cleared a bit-array of host event statuses that could never actually be set via public APIs, i.e. the pd_host_send_event() function because the aforementioned function was moved to a different source file. Move the pd_host_send_event() back to usb_pd_host_cmd.c so it can actually update the static event status bit-array. Validate this change by testing the host command status attribute in its response after invoking pd_send_host_event(). Also allow the EC_CMD_PD_HOST_EVENT_STATUS to be compiled in test builds and instead disable it for the one incompatible test (charge ramp). BRANCH=none BUG=b:236075275 BUG=b:249574372 TEST=twister --clobber -i -s zephyr/test/drivers/drivers.host_cmd TEST=make runhosttests -j TEST=make BOARD=fusb307bgevb -j Signed-off-by:
Aaron Massey <aaronmassey@google.com> Change-Id: I548fc6c6eed3a2eab6e2c9b7d8862f4cc0786c12 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3924807 Reviewed-by:
Jeremy Bettis <jbettis@chromium.org> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
-
- 28 Sep, 2022 1 commit
-
-
Yi Chou authored
There are some EC_CMD are greater than 0xFF (e.g. FP. PD...), the ectool should support the v1 cmdversion to get the command version for those 16 bits command code command. BUG=b:248508087 TEST=ectool --name cros_fp cmdversions 0x400 BRANCH=none Signed-off-by:
Yi Chou <yich@google.com> Change-Id: I07c6e9b3d0472259e0899807ca699efa1b00786f Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3920539 Reviewed-by:
Eric Yilun Lin <yllin@google.com>
-
- 26 Sep, 2022 2 commits
-
-
Jeremy Bettis authored
This reverts commit 6cc204a4. Reason for revert: Broke gitlab (https://gitlab.com/zephyr-ec/ec/-/pipelines/651162463) and also CQ emerge builds (https://ci.chromium.org/ui/p/chromeos/builders/postsubmit/nissa-postsubmit/16030/overview ) Original change's description: > common: replace safe_memcmp with cryptoc version > > We now have to always link against cryptoc, but it does not increase > code size on our most constrained boards: > > Before and after both show: > > Smallest free spaces in RO flash (bytes): > pdeval-stm32f072: 88 > servo_v4 : 104 > fusb307bgevb: 156 > > Smallest free spaces in RW flash (bytes): > volteer : 516 > bobba : 712 > meep : 716 > > Tightest boards' RW RAM images, bytes free: > whiskers : 212 > minimuffin: 284 > zinger : 284 > > BRANCH=none > BUG=b:169156874 > TEST=make buildall > > Signed-off-by:
Tom Hughes <tomhughes@chromium.org> > Change-Id: I98422eccb3e903bd82ddb386087dd2d55d1f845e > Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2424068 > Reviewed-by:
Denis Brockus <dbrockus@chromium.org> > Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Bug: b:169156874 Change-Id: I794ae31f9e217677471b0ff164fadc9623571a33 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3919500 Commit-Queue: Raul Rangel <rrangel@chromium.org> Commit-Queue: Jeremy Bettis <jbettis@chromium.org> Reviewed-by:
Raul Rangel <rrangel@chromium.org> Tested-by:
Jeremy Bettis <jbettis@chromium.org> Auto-Submit: Jeremy Bettis <jbettis@chromium.org>
-
Tom Hughes authored
We now have to always link against cryptoc, but it does not increase code size on our most constrained boards: Before and after both show: Smallest free spaces in RO flash (bytes): pdeval-stm32f072: 88 servo_v4 : 104 fusb307bgevb: 156 Smallest free spaces in RW flash (bytes): volteer : 516 bobba : 712 meep : 716 Tightest boards' RW RAM images, bytes free: whiskers : 212 minimuffin: 284 zinger : 284 BRANCH=none BUG=b:169156874 TEST=make buildall Signed-off-by:
Tom Hughes <tomhughes@chromium.org> Change-Id: I98422eccb3e903bd82ddb386087dd2d55d1f845e Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2424068 Reviewed-by:
Denis Brockus <dbrockus@chromium.org> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
-
- 23 Sep, 2022 1 commit
-
-
Tom Hughes authored
BRANCH=none BUG=b:248361020 TEST=CQ passes Signed-off-by:
Tom Hughes <tomhughes@chromium.org> Change-Id: Ie3067e40c40f2734a4c35cfaf0552cadf132eaf6 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3914986 Reviewed-by:
Diana Z <dzigterman@chromium.org>
-
- 22 Sep, 2022 1 commit
-
-
Tom Hughes authored
The utils only run on the host, so we have no restrictions on compiler. Use C++ so that ectool can use "libec". BRANCH=none BUG=b:144959033 TEST=make buildall Force-Relevant-Builds: all Signed-off-by:
Tom Hughes <tomhughes@chromium.org> Change-Id: I44b9bb25b2659b678bc4b71e203a1901eff51b13 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2556757 Reviewed-by:
Yuval Peress <peress@google.com> Code-Coverage: Yuval Peress <peress@google.com>
-
- 20 Sep, 2022 1 commit
-
-
Aaron Massey authored
The number "32" is a parameter in multiple zassert invocations in the virtual battery test. Although this number isn't entirely magic, it may make tests brittle when asserting against a new version of the smart battery specification that doesn't use 32 bit size values. Replace these values with a defined constant in battery.h BRANCH=none BUG=b:246652125 TEST=./twister --clobber -i -s zephyr/test/drivers/drivers.default Signed-off-by:
Aaron Massey <aaronmassey@google.com> Change-Id: I8d85ca7e4d42320559e4631b853a6db30b1aa000 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3902456 Reviewed-by:
Jeremy Bettis <jbettis@chromium.org> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
-
- 16 Sep, 2022 1 commit
-
-
Tom Hughes authored
g++ gives an error when using a flexible array member as the only member of a struct, but works with the zero-length array extension. BRANCH=none BUG=b:234181908 TEST=./util/compare_build.sh -b all -j 120 => MATCH Signed-off-by:
Tom Hughes <tomhughes@chromium.org> Change-Id: I89775cef72cd0adaa77c8b4f281ed0327696d4f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3894404 Reviewed-by:
Jack Rosenthal <jrosenth@chromium.org>
-
- 14 Sep, 2022 2 commits
-
-
Abe Levkoy authored
Remove VPD support functions that are not used anywhere. Reduce coverable lines of code. BUG=b:246363751 TEST=make buildall BRANCH=none Signed-off-by:
Abe Levkoy <alevkoy@chromium.org> Change-Id: Idf51827ff3b0abdc2b202c5eaae02ead23df6656 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3891684 Reviewed-by:
Diana Z <dzigterman@chromium.org> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
-
Abe Levkoy authored
TCPMv1 has not been used for TBT or USB4 for some time. Remove this support to make it easier to refactor TBT and USB4 code. LOW_COVERAGE_REASON=TCPMv1 is known to be buggy but is deprecated; its behavior is hard to describe but should not be changed. BUG=b:244218024 TEST=make BOARD=careena; DP monitor behavior same as ToT BRANCH=none Signed-off-by:
Abe Levkoy <alevkoy@chromium.org> Change-Id: Ia02ce7a2500b83e3147ec5737134a009a59ea288 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3887961 Reviewed-by:
Diana Z <dzigterman@chromium.org> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
-
- 13 Sep, 2022 2 commits
-
-
Tom Hughes authored
This change allows us to use flexible array members in both C and C++. BRANCH=none BUG=b:234181908 TEST=./util/compare_build.sh -b all -j 120 => MATCH Signed-off-by:
Tom Hughes <tomhughes@chromium.org> Change-Id: Ia62b27507cebbe14c9f5f618a6cf1133859cbe92 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3893044 Reviewed-by:
Yuval Peress <peress@google.com>
-
Reka Norman authored
This reverts commit 884cdd68 . Reason for revert: This breaks EC sync in depthcharge (see b:246211747 and CL:3890017). I was going to just fix the depthcharge case, but there are also a lot of places in the EC which rely on `sizeof(struct ec_params_flash_write)` being equal to the header size (e.g. flash_command_write(), flash_command_get_info(), ec_flash_write()), so these all need to be changed too. Original change's description: > ec_commands: Fix C++ compilation > > This union has non-zero size in C++. > > BRANCH=none > BUG=b:234181908 > TEST=make buildall > > Signed-off-by:
Tom Hughes <tomhughes@chromium.org> > Change-Id: Ibd1216ebdef1d94725e7b3de341f677ccd261823 > Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3872550 > Reviewed-by:
Yuval Peress <peress@google.com> Bug: b:246211747 Change-Id: I52508e2ec3c5a8b6224678bb655caa575f403842 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3891559 Reviewed-by:
Sam McNally <sammc@chromium.org> Auto-Submit: Reka Norman <rekanorman@chromium.org> Tested-by:
Reka Norman <rekanorman@chromium.org> Commit-Queue: Sam McNally <sammc@chromium.org>
-
- 12 Sep, 2022 1 commit
-
-
Mike Frysinger authored
Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. BRANCH=none BUG=chromium:1098010 TEST=`repo upload` works Change-Id: Icd3a1723c20595356af83d190b2c6a9078b3013b Signed-off-by:
Mike Frysinger <vapier@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3891203 Reviewed-by:
Jeremy Bettis <jbettis@chromium.org> Reviewed-by:
Jack Rosenthal <jrosenth@chromium.org>
-
- 09 Sep, 2022 1 commit
-
-
Michał Barnaś authored
Rename ESPI additional configs to match the name of base config that selects ESPI as HOST_INTERFACE. BUG=b:195416058 BRANCH=main TEST=zmake testall && make buildall Change-Id: I137449a1a58b1ea0d9794ebc0900e1b68413819d Signed-off-by:
Michał Barnaś <mb@semihalf.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3291744 Reviewed-by:
Sam Hurst <shurst@google.com> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
-
- 08 Sep, 2022 1 commit
-
-
Tom Hughes authored
This union has non-zero size in C++. BRANCH=none BUG=b:234181908 TEST=make buildall Signed-off-by:
Tom Hughes <tomhughes@chromium.org> Change-Id: Ibd1216ebdef1d94725e7b3de341f677ccd261823 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3872550 Reviewed-by:
Yuval Peress <peress@google.com>
-
- 02 Sep, 2022 1 commit
-
-
Scott Chao authored
In USB Power Delivery Specification Revision 3.1, Version 1.5, the tSenderResponse have changed to min 26/ max 32 ms. BUG=b:242021187 BRANCH=none TEST=verify pass on TEST.PD.PROT.SRC.3 Signed-off-by:
Scott Chao <scott_chao@wistron.corp-partner.google.com> Change-Id: I470414d20d628425022634fbf9b9ef4c807df603 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3868871 Reviewed-by:
Diana Z <dzigterman@chromium.org> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
-
- 01 Sep, 2022 2 commits
-
-
Tristan Honscheid authored
Test the crec_flash_is_erased() function. Add a union of zero-length arrays to `struct ec_params_flash_write` for convenience BRANCH=None BUG=b:236074365 TEST=./twister Signed-off-by:
Tristan Honscheid <honscheid@google.com> Change-Id: Ica8fd3ce19fca3c87c0c0a2be8732dda6691cce4 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3865658 Reviewed-by:
Simon Glass <sjg@chromium.org>
-
Scott Chao authored
According to USB Power Delivery Compliance Test Specification, Revision 1.4 Version 4(TEST.PD.PROT.SRC.10#3). UUT should send Type-C error recovery within tPSSourceOn. From the TEST.PD.PROT.SRC.10 test result, UUT sent Type-C Error Recovery after tPSSourceOn_Max(480ms).The time interval is 0.4896s which is exceeded the max timing(480ms). So I pick the value in the middle of 390ms and 480ms. BUG=b:242119728 BRANCH=none TEST=pass TEST.PD.PROT.SRC.10 Signed-off-by:
Scott Chao <scott_chao@wistron.corp-partner.google.com> Change-Id: Icef77701eaadad71a204debe00f174d05eeceeae Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3865416 Reviewed-by:
Diana Z <dzigterman@chromium.org>
-
- 31 Aug, 2022 1 commit
-
-
Yuval Peress authored
Exercise some of the panic output API. Some of the basic printing API cannot yet be fully tested. But a fix upstream is coming to allow us to use the 'console' harness features to parse the output log and pass/fail the test based on output. BRANCH=none BUG=none TEST=twister -s zephyr/test/drivers/drivers.default Signed-off-by:
Yuval Peress <peress@google.com> Change-Id: I8e56e8bcdaa0e095891c38a26e56ced8f3a8d4d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3855593 Reviewed-by:
Simon Glass <sjg@chromium.org> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
-
- 27 Aug, 2022 1 commit
-
-
Diana Z authored
Add a macro to generate passive cable VDOs and exactly enough enums to cover fields which have 0 as a reserved value. BRANCH=None BUG=b:243151272 TEST=zmake buildall Signed-off-by:
Diana Z <dzigterman@chromium.org> Change-Id: Ieff7eb9e9fa585d13b54d4c1c183467df5fc20b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3859562 Commit-Queue: Abe Levkoy <alevkoy@chromium.org> Reviewed-by:
Abe Levkoy <alevkoy@chromium.org>
-